Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Possibilities to add ButtonID to Confirmation Dialog #464

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Added Possibilities to add ButtonID to Confirmation Dialog #464

wants to merge 2 commits into from

Conversation

Crixu
Copy link

@Crixu Crixu commented Nov 28, 2024

Description

This PR introduces the ability to set a custom ID or CSS selector for the confirmation button in NewConfirmationDialog. This enhancement enables better feature usage tracking in Pendo.

Related Issue: #463

Steps to Test

Outline the steps to test and verify the PR here.

Example:

  1. Pull down PR.
  2. npm run dev.
  3. Open Storybook.
  4. Go to /docs/dialog-newconfirmationdialog--docs.
  5. Verify buttonID "ConfirmIsJohnDoe" is present

@netlify Netlify
Copy link

netlify bot commented Nov 28, 2024 •
edited
Loading

✅ Deploy Preview for vip-design-system-components ready!

Name Link
🔨 Latest commit 27e30e1
🔍 Latest deploy log https://app.netlify.com/sites/vip-design-system-components/deploys/674825776c3b2c0008035b55
😎 Deploy Preview https://deploy-preview-464--vip-design-system-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

djalmaaraujo
djalmaaraujo requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@djalmaaraujo djalmaaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Crixu Thanks for your contribution, but using buttonId is not a standard name, especially in this case that it's going to Close button, but you are passing in a parent component. This property will be confusing for users, not knowing where this ID is being applied.

But even better would be for you to use a better CSS selector in pendo, instead of relying on IDS. Can you to the query from a upper component, like: "#parentId button?

@Crixu
Copy link
Author

Crixu commented Nov 28, 2024 •
edited
Loading

@Crixu Thanks for your contribution, but using buttonId is not a standard name, especially in this case that it's going to Close button, but you are passing in a parent component. This property will be confusing for users, not knowing where this ID is being applied.
But even better would be for you to use a better CSS selector in pendo, instead of relying on IDS. Can you to the query from a upper component, like: "#parentId button?

The goal is to get an ID added to the confirm button which was achieved in this case. In the Storybook Playground I only see the ID attached to the confirm button.
If I use the #parentId button CSS selector I can't differentiate between the close or the confirm button.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djalmaaraujo djalmaaraujo djalmaaraujo requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
[Status] Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Crixu @djalmaaraujo